nextcloud / spreed

How to use GitHub

Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Have a team (circle) "office team" that has a admin defined group "office" as members
The circle is a participant on a talk conversation
Admin adds a user to the "office" group
The user gets access to the talk conversation through the "office team" circle

Expected behaviour

"An administrator added User" or something similar

Actual behaviour

Talk app

Talk app version: 18.0.5

Custom Signaling server configured: yes

Custom TURN server configured: yes

Custom STUN server configured: yes

Skipped the following information as browser seems irrelevant and it is our instance

Browser

Microphone available: yes/no

Camera available: yes/no

Operating system: Windows/Ubuntu/...

Browser name: Firefox/Chrome/...

Browser version: 85/96/...

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

Operating system: Ubuntu/RedHat/...

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.0/8.1/8.2

Nextcloud Version: (see admin page)

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Server log (data/nextcloud.log)

Insert your server log here

Should try to end up with this actor selection somehow:

spreed/lib/Chat/SystemMessage/Listener.php

Lines 476 to 478 in 1ccbf67

    
           } elseif (\OC::$CLI || $this->session->exists('talk-overwrite-actor-cli')) { 
        
           	$actorType = Attendee::ACTOR_GUESTS; 
        
           	$actorId = Attendee::ACTOR_ID_CLI;

	} elseif (\OC::$CLI \|\| $this->session->exists('talk-overwrite-actor-cli')) {
	$actorType = Attendee::ACTOR_GUESTS;
	$actorId = Attendee::ACTOR_ID_CLI;

System message shows "guest added user" to a conversation when adding through circle/team