nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud

Home Page:https://nextcloud.com/talk

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Message expiration is not hidden when not supported by the server

SystemKeeper opened this issue · comments

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Use ajax for background jobs
  2. Open conversation settings

Expected behaviour

Message expiration should be hidden, since it is not available for ajax background jobs:

spreed/lib/Capabilities.php

Lines 206 to 208 in 59cc7eb

if ($this->serverConfig->getAppValue('core', 'backgroundjobs_mode', 'ajax') === 'cron') {
$capabilities['features'][] = 'message-expiration';
}

Actual behaviour

The option is visible

Talk app

Talk app version: main

Doesn't seem to be a regression...

Also an issue for the desktop client when talking to an old server