nextcloud / notifications

:bell: Notifications app for Nextcloud

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Browser notification not blocked while in DnD mode

PVince81 opened this issue Β· comments

How to use GitHub

  • Please use the πŸ‘ reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Setup Nextcloud 25.0.1 with the matching Talk version
  2. Open Talk
  3. Allow the browser to send notifications
  4. Set status to "Do not disturb"
  5. Have someone ping you privately or in a group chat

Expected behaviour

No browser notification sent.

Actual behaviour

Browser notification still arriving.

Talk app

Talk app version: the one from c.nc.com

Browser

Operating system: openSUSE Tumbleweed

Browser name: Firefox

Browser version: 107.0

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

Nextcloud Version: 25.0.1 (c.nc.com)

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Server log (data/nextcloud.log)

Insert your server log here

showBrowserNotifications() {
return this.backgroundFetching
&& this.webNotificationsGranted
&& this.userStatus !== 'dnd'
&& this.tabId === this.lastTabId

It should...

But maybe it's never refreshing the state

Hmm so it's refreshing only with the notification polling. But when notify_push is used that happens only every 15 minutes.
Can you confirm that you changed your status within 15 minutes before receiving the notification?

@nickvergessen I don't remember, it felt like I had set it earlier but can't confirm

it did look like I received the notification within a minute or two of Andy posting

@nickvergessen I just got pinged in private and didn't receive a notification, so your theory about the 15 minutes might be correct

still, it would be good to find a way to block this. usually the first minutes of setting to DnD is when I feel the most frustrated (and other users possibly too), so receiving more notifications there is more annoying πŸ˜„

not sure if blocking also on desktop client level makes sense also

not sure if blocking also on desktop client level makes sense also

Yeah, if DND is set the desktop should not show notifications. They might interfer with screenshares etc.