Build error on older kernels

[Luigi Baldoni]

I'm seeing this sort of problem on 3.12 and older

gcc -Wp,-MD,/home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/.rt2800pci.o.d  -nostdinc -isystem /usr/lib/gcc/i586-suse-linux/4.8/include -I/usr/src/linux-3.11.6-4/arch/x86/include -Iarch/x86/include/generated  -I/usr/src/linux-3.11.6-4/include -Iinclude -I/usr/src/linux-3.11.6-4/arch/x86/include/uapi -Iarch/x86/include/generated/uapi -I/usr/src/linux-3.11.6-4/include/uapi -Iinclude/generated/uapi -include /usr/src/linux-3.11.6-4/include/linux/kconfig.h   -I/home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00 -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -m32 -msoft-float -mregparm=3 -freg-struct-return -fno-pic -mpreferred-stack-boundary=2 -march=i586 -mtune=generic -maccumulate-outgoing-args -Wa,-mtune=generic32 -ffreestanding -fstack-protector -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 -pipe -Wno-sign-compare -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -Wframe-larger-than=2048 -Wno-unused-but-set-variable -fomit-frame-pointer -fasynchronous-unwind-tables -g -fno-inline-functions-called-once -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO  -DMODULE  -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(rt2800pci)"  -D"KBUILD_MODNAME=KBUILD_STR(mt7630e)" -c -o /home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/.tmp_rt2800pci.o /home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2800pci.c
In file included from /home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2x00.h:40:0,
                 from /home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2800pci.c:43:
/home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2800pci.c: In function 'rt2800pci_txstatus_interrupt':
/usr/src/linux-3.11.6-4/include/linux/kfifo.h:395:11: warning: assignment makes pointer from integer without a cast [enabled by default]
   __dummy = (typeof(__val))NULL; \
           ^
/home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2800pci.c:1454:8: note: in expansion of macro 'kfifo_put'
   if (!kfifo_put(&rt2x00dev->txstatus_fifo, status)) {
        ^
/usr/src/linux-3.11.6-4/include/linux/kfifo.h:398:47: error: invalid type argument of unary '*' (have 'u32')
   __ret = __kfifo_in_r(__kfifo, __val, sizeof(*__val), \
                                               ^
/home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2800pci.c:1454:8: note: in expansion of macro 'kfifo_put'
   if (!kfifo_put(&rt2x00dev->txstatus_fifo, status)) {
        ^
/usr/src/linux-3.11.6-4/include/linux/kfifo.h:392:9: warning: passing argument 2 of '__kfifo_in_r' makes pointer from integer without a cast [enabled by default]
  struct __kfifo *__kfifo = &__tmp->kfifo; \
         ^
/home/abuild/rpmbuild/BUILD/MT7630E-2.0.8/obj/default/rt2x00/rt2800pci.c:1454:8: note: in expansion of macro 'kfifo_put'
   if (!kfifo_put(&rt2x00dev->txstatus_fifo, status)) {
        ^
/usr/src/linux-3.11.6-4/include/linux/kfifo.h:819:21: note: expected 'const void *' but argument is of type 'u32'
 extern unsigned int __kfifo_in_r(struct __kfifo *fifo,
                     ^

Is there anything I can do?

[Julen Diez]

I had the same problem and I modified rt2800pci.c file but had some troubles with connection so finally decide to update the kernel.

[Luigi Baldoni]

Well, since 3.12 will be EOL in 3 months, I suppose it's pointless to insist.