Giters

nette / php-generator

🐘 Generates neat PHP code for you. Supports new PHP 8.3 features.

Home Page:https://doc.nette.org/php-generator

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Promoted properties & reflection consistency

jkuchar opened this issue · comments

commented

We have built grifart/caffolder on top of php-generator. As we need to also read the state from php-generator I have found an inconsistency with php-reflection.

With php reflection you get properties & promoted properties when retrieving $class->getProperties(). However when using php generator one has to use $class->getProperties() for old-style properties and $class->getMethod('__construct')->getParameters(). See this utils method for more info.

Wouldn't it be nicer to have property accessible directly using $class->getProperties()?

commented

It would be a BC break, I don't really want to deal with it.

commented

Also it does not make sense to me. PhpGenerator internal structure is AST-like, meaning it corresponds to the code structure, not to the code meaning. So for example PHP reflection will also return methods from traits/parents, but PhpGenerator will not.