netopyr / reduxfx

Functional Reactive Programming (FRP) for JavaFX

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ReduxFxml create function; shouldn't it take a store (v0.4.1)?

chris-jan-dudley opened this issue · comments

Hi Guys,

We've been using ReduxFx, and following your ReduxFxml example. in the FxmlExample.java file you have the following line (34):

ReduxFxml<AppState> reduxFxml = ReduxFxml.create(store);

However, in our project, pulling the latest version from Maven (v0.4.1) the create function does not seem to take a ReduxFXStore parameter, as your example code suggests? Is this a known inconsistency, or is the example outdated?

Many thanks!

This change was done in the latest commit.
This example code shows the usage of v0.4.2-SNAPSHOT.

So the example code is consistent for v0.4.2 but not v0.4.1.
However, as this is an API breaking change the version isn't compatible with semantic versioning.
Should it be v0.5.0?

I'm waiting v0.5.0.