Test plugin with old versions of Gatsby
ascorbic opened this issue · comments
Currently the latest version of the plugin requires Gatsby 4, but there's nothing specific that demands this. We should test this with Gatsby 3 and Gatsby 2 to ensure that a) it works with Gatsby Functions in Gatsby 3, and b) that in older versions it doesn't generate any functions. If this is confirmed, we should update plugins.json to reflect that
Is this something we still want to look at @ascorbic and if so, would it be reasonable to look at just v3, or should we still consider v2?
It's lower priority, but I think it would be worth checking. It's a relatively simple one, because it doesn't support any form of SSR/DSG or functions, so it would just be checking that a) it doesn't break and b) that it saves and restores the cache
@seldo - Do we have any data on which version of Gatsby people are using?
Sure do! https://app.mode.com/netlify/reports/00342b250700/runs/bfbe51689650
TLDR: in the last 30 days about 13k accounts built with Gatsby. Of those about half are on version 4; the next most popular version is 2, which about 25% of builds used. More details if you click through to Mode.
Awesome, this is really useful. For reference, version 2 of Gatsby is no longer officially supported by Gatsby themselves https://www.gatsbyjs.com/docs/reference/release-notes/gatsby-version-support/
From this data supporting v3 is a no-brainer. Anybody still using v2 is probably not paying enough attention to care about whether we support them or not.
Great! Could you also try it with netlify serve?
Everything is working when running ntl serve
Great! I'd say let's go ahead an update the package.json and plugins.json
Updated plugin PR netlify/plugins#1104