Service worker prevents function calls

Question

Service worker prevents function calls

lgraubner opened this issue 6 years ago · comments

As the service worker seems to be the "official" one I assume it can't be used like this in combination with functions.

facebook/create-react-app#2237 (comment)

The Service worker will just return the app instead of the function itself. Only option is ejecting and extend navigateFallbackWhitelist option.

I didn't test this with this package, but with a bare CRA app and functions which should be basically the same.

swyx.io · Answer 1 · Thu Oct 18 2018 01:48:45 GMT+0800 (China Standard Time)

Hi Lars, sorry for the super super late response. i just joined the team.

Its been a long while so I'm gonna assume this is stale. but if you still need this looked at please feel free to reopen!

Lars Graubner · Answer 2 · Thu Oct 18 2018 04:07:31 GMT+0800 (China Standard Time)

Hi Shawn, thanks for your response.

I think this is still relevant as this boilerplate will not work like this. Please correct me if I'm wrong. :)

Only solution for me was to eject and adjust the webpack config.

swyx.io · Answer 3 · Thu Oct 18 2018 04:15:06 GMT+0800 (China Standard Time)

i mean for what its worth the service worker is off by default in CRA v2. i never use it.

Lars Graubner · Answer 4 · Sat Oct 20 2018 05:11:04 GMT+0800 (China Standard Time)

This wasn't the case for v1. :) I'd suggest adding a note to the README to prevent other people from running into the same problem. I'm willing to create a PR if you like.