Migrate source to Swift 3.0

Question

Migrate source to Swift 3.0

akashivskyy opened this issue 8 years ago · comments

Source files should be migrated to Swift 3.0. API should be updated to conform to Swift API Guidelines, potentially breaking source compatibility. ¯_(ツ)_/¯

Oleksandr Skrypnyk · Answer 1 · Thu Sep 15 2016 21:54:35 GMT+0800 (China Standard Time)

Hi guys, do you have any ETA for Swift 3 compatible version?

Adrian Kashivskyy · Answer 2 · Fri Sep 16 2016 22:28:05 GMT+0800 (China Standard Time)

No, but I think we'll start working on that next week. I'll keep you updated. 🙂

Serhii Butenko · Answer 3 · Sat Jan 21 2017 00:25:37 GMT+0800 (China Standard Time)

Hi @akashivskyy! I'm working on the issue. Existing code base is already migrated, now I'm fixing tests and then I'm gonna update API to be more Swifty. While fixing tests, I got a failed ConsoleOutputFacilitySpec tests. As far as I understood you rely on objects order in dictionary. It fails because headers have different order:
actual:

"X-Baz": "qux"
"X-Foo": "bar",

expected:

"X-Foo": "bar",
"X-Baz": "qux"

Adrian Kashivskyy · Answer 4 · Sat Jan 21 2017 02:06:51 GMT+0800 (China Standard Time)

I'm working on the issue. Existing code base is already migrated, now I'm fixing tests and then I'm gonna update API to be more Swifty.

Fantastic! ✨

As far as I understood you rely on objects order in dictionary. It fails because headers have different order:

Yeah, I agree that was kind of dumb on my side. If you'd like to change how the test behaves, feel free to do so. 😉