E2e tests fail with version 2.1.1

[vdechef]

I'm submitting a...

[x] Regression 
[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When running e2e tests, @nestjs/serve-static uses noop loader.
Consequently, my tests for routing are failing because serve-static returns a 404 error on non-existing routes, instead of serving the index.html of the root folder.

With version 2.1.0, when running e2e tests serve-static was using express loader instead of noop loader. So when requesting http://myserver/non-existing-path serve-static was returning a response 200 with /index.html as content.

The culprit is this commit : db6e86d#diff-b38ccc22d6bb4ce4c12a2c61b89a974b

Expected behavior

Testing the routing of @nestjs/serve-static should be possible.

Minimal reproduction of the problem with instructions

• Create a NestJS project
• Add a static folder to serve, following the documentation : https://docs.nestjs.com/recipes/serve-static
• Ensure that the folder is correctly served when running the server
• Add end-to-end test following the documentation : https://docs.nestjs.com/fundamentals/testing#end-to-end-testing
• try to request the folder
  => test will fail with an error 404

Doing the same with @nestjs/serve-static 2.1.0 will succeed

Environment

Nest version: 7.1.3
 
For Tooling issues:
- Node version: 12.16.2
- Platform:  Linux

[Kamil Mysliwiec]

Wouldn't it be easier to simply use the NestFactory.create() instead? TestModule bootstraps providers before knowing whether the simulated Nest environment will act as an HTTP application, Microservice, etc.

[vdechef]

Sorry, I'm not sure to understand what you mean.

In my tests code, I do something like this to initialise the NestJS server and run a simple GET request againt it :

    const moduleFixture: TestingModule = await Test.createTestingModule({
        imports: [AppModule],
    }).compile()
    const app = moduleFixture.createNestApplication()
    await app.init()
    const serv = app.getHttpServer()

    let response = await request(serv).get("/myendpoint")
    expect(response.body).toEqual("My endpoint was called")

You mean that it could be done with NestFactory.create() instead ?

[Kamil Mysliwiec]

You can use the following code instead:

    const app = NestFactory.create(AppModule);
    await app.init();
    const serv = app.getHttpServer()

    let response = await request(serv).get("/myendpoint")
    expect(response.body).toEqual("My endpoint was called")

[vdechef]

Indeed, it work. Thanks for the support!

So if I understand correctly, for end-to-end tests I should instanciate the whole NestJS application. And I should stick to TestingModule for unit-testing of individual modules.