Semi PR Request (upgrades in azure library)
Setitch opened this issue · comments
I'm submitting a...
[ ] Regression
[ ] Bug report
[X] Feature request
[X] Question and example answer
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
Nest version is old, @azure/storage-blob is old.
Cannot use key, connectionString nor any new authorization method.
Cannot use delete, download methods of library (they are nor written)
Expected behavior
Minimal reproduction of the problem with instructions
just download this version and all problems ocures.
What is the motivation / use case for changing the behavior?
Upgrade versions and add more functionality
##Example of fix
I rewrote some files - tests works - as i needs stated features asap. Only one thing i got (after upgrading) is error of:
TypeError: Cannot read property 'kind' of undefined
| const ms = node.moduleSpecifier;
| let modulePath;
> | switch (ms.kind) {
which im not able to even understand (i mean i never ever used such features of node).
So what im asking is to look at my repo and maybe incorporate what you thing is wrote ok or give me hints how to fix the issue i have now (which forbids building the library for npm).
Link to repo: https://github.com/Setitch/azure-storage
@Setitch would you mind opening a PR (even if it's incomplete)? We can review it together.
Thank you for answering, i made the PR for your review. I use the version from it on production project already (needed progress bars for upload/download) and also deleting and some other options that was lacking from nestjs version.
What is not working in my version are tests and after some time i stopped working on them as sadly not much time and i do not really get some of them (like error i got, i totally dont get it)
@manekinekko When you would have time to review it? So we can do that together