Giters

nerdsupremacist / Graphaello

A Tool for Writing Declarative, Type-Safe and Data-Driven Applications in SwiftUI using GraphQL

Home Page:https://graphaello.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Xcode 11.4 will not build.

nonfungibletunji opened this issue · comments

commented

SwiftSyntax parser library isn't compatible
Command PhaseScriptExecution failed with a nonzero exit code

commented

Interesting issue!

I have not tried with the 11.4 Release yet. Only the Beta...
I'll update to Xcode 11.4 and check it out...
My guess is that apple moved the location of libSwiftSyntax.dylib... nope that wasn't it

Did you have Xcode 11.4 installed as the main Xcode (xcode-select -p) during installation?

commented

Also I'm moving this issue to the Graphaello repo:

This looks more like an issue with the makefile of the CLI

commented

/Applications/Xcode.app/Contents/Developer
yes brand new install

commented

Ok. I was able to reproduce the issue.

Thanks I'll come up with a fix soon

commented

Alright. I did some digging...

Looks like the version of SwiftSyntax needs to match the version of libSwiftSyntax.dylib perfectly.

So I'll update the version of it to use Swift 5.2... and force Xcode 11.4 in the brew formula

It's a good thing that this came up while it's still in Alpha. We will need to come up with a way to make sure the versions match during install.

It's fuzzy wether or not we're allowed to just ship Graphaello with libSwiftSyntax.dylib in the repo directly.
I assume that would be a License or Terms and Conditions infringement, so I would prefer if we can do this via home-brew somehow...

commented

@stunjiturner I have a fix, but apple hasn't released SwiftSyntax for 5.2 yet. They just have a branch for it.
So I'm not comfortable replacing the current version with that, yet.

I made a Graphaello branch for it as well, now.
If you want to use it you can

First make sure you uninstall Graphaello first:

brew uninstall graphaello

Then you clone it and install from source:

git clone https://github.com/nerdsupremacist/Graphaello.git
cd graphaello
git checkout swift-5.2-branch
sudo make install

I hope this helps! 🙃

commented
commented

My bad. Didn't actually test it on the project... I just checked if codegen went through...

I believe I fixed it. But SwiftSyntax got a lot of Breaking Changes.
And I'm not sure if this branch is 100% ready... But you're welcome to try it.

To update go to your cloned source of Graphaello and run:

sudo make uninstall
git pull
sudo make install

I tried it and it works without a hitch for the countries example.

And you don't need to run codegen yourself. The Build Phase that was failing does it for you ;)

commented

@stunjiturner I released the version with the changes. If you want to you can install the version from brew again

commented