Update return type for `columns` function prop to `number | undefined`
AleksandrHovhannisyan opened this issue · comments
The way the code is written here (two if
statements) suggests that the columns
function prop can technically return undefined
, allowing a user to fall back to the default internal calculations in the if
statement on L82:
react-photo-gallery/src/Gallery.js
Lines 76 to 87 in 0bb8e4c
I was able to verify this locally. However, the return type for this function is strictly number
, so I get type errors if I try to return undefined
from the function:
react-photo-gallery/src/Gallery.js
Line 120 in 0bb8e4c
I think it would be nice to update the prop types to allow returning undefined
since it seems to work as expected: I can either specify custom logic or return undefined
to signal that I want to fall back to the default calculations.
Alternatively, the function could accept a second argument—the default number of columns for containerWidth
—so you could do something like this:
columns={(containerWidth, defaultNumColumns) => containerWidth <= 320 ? 2 : defaultNumColumns}
Happy to put in a PR for this if you approve.