neondatabase / pg_embedding

Hierarchical Navigable Small World (HNSW) algorithm for vector similarity search in PostgreSQL

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

:bug: Installation Issue

jordanparker6 opened this issue · comments

Steps to reproduce

make
suod make install

Expected result

Trying to install pg_embedding

Actual result

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -Ofast -fPIC -I. -I./ -I/usr/include/postgresql/15/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o distfunc.o distfunc.c
distfunc.c: In function ‘l2_dist_impl_avx2’:
distfunc.c:20:5: error: ISO C90 forbids array ‘partial_result’ whose size cannot be evaluated [-Werror=vla]
   20 |     float partial_result[elts_per_vector];
      |     ^~~~~
distfunc.c:30:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   30 |         __m256 vecX2 = _mm256_loadu_ps(x + i + elts_per_vector);
      |         ^~~~~~
distfunc.c:37:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   37 |     float res1 = partial_result[0] + partial_result[4];
      |     ^~~~~
distfunc.c:45:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   45 |     size_t tail_size = n % elts_per_loop;
      |     ^~~~~~
cc1: some warnings being treated as errors

Environment

Debian 11

It would also be nice to include installation notes in the README.md

Environment centos7.6 gcc 11.2 same error