Breaking changes in 5.7
djmattyg007 opened this issue · comments
It looks like there were some breaking changes in 5.7 that means code generated with 5.6 simply doesn't work with 5.7. I tested with the latest commits on master in this repo, and I'm still seeing issues.
Is this expected, or is it a mistake? If it is expected, would you be able to provide details of what those expected breakages are?
Even regenerating the code doesn't with 5.7 doesn't fix the problems I'm seeing :(
Okay, the issue appears to be that the default values for comments_re and eol_comments_re changed, and I can't work out how to override the settings. Passing comments_re=None, eol_comments_re=None to the parser constructor does nothing.
This is how I fixed the issue for my codebase while maintaining compatibility with Tatsu 5.6:
djmattyg007/python-cuddle@a8d8316
To sum up, there's two issues:
- I can't override these properties by passing them to the parser constructor
- The default values for these settings changed in a minor release
There are fixes for this use case in the upcoming v5.8.0. Could you check against the master branch?
Could yo revisit this against the latest Tatsu, @djmattyg007 ?