Signs not sowing in vim when `signcolumn=number` and vim version `8.2.2850`
luisdavim opened this issue · comments
Reopening #176 that was reopening #174
Hi, I've noticed that using the same config the gutter signs stopped working for vim with the last update whilst they still work with nvim
vi --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 13 2021 18:23:10)
macOS version - x86_64
Included patches: 1-2850
Compiled by Homebrew
Huge version without GUI. Features included (+) or not (-):
+acl -farsi +mouse_sgr +tag_binary
+arabic +file_in_path -mouse_sysmouse -tag_old_static
+autocmd +find_in_path +mouse_urxvt -tag_any_white
+autochdir +float +mouse_xterm -tcl
-autoservername +folding +multi_byte +termguicolors
-balloon_eval -footer +multi_lang +terminal
+balloon_eval_term +fork() -mzscheme +terminfo
-browse +gettext +netbeans_intg +termresponse
++builtin_terms -hangul_input +num64 +textobjects
+byte_offset +iconv +packages +textprop
+channel +insert_expand +path_extra +timers
+cindent +ipv6 +perl +title
-clientserver +job +persistent_undo -toolbar
+clipboard +jumplist +popupwin +user_commands
+cmdline_compl +keymap +postscript +vartabs
+cmdline_hist +lambda +printer +vertsplit
+cmdline_info +langmap +profile +virtualedit
+comments +libcall -python +visual
+conceal +linebreak +python3 +visualextra
+cryptv +lispindent +quickfix +viminfo
+cscope +listcmds +reltime +vreplace
+cursorbind +localmap +rightleft +wildignore
+cursorshape +lua +ruby +wildmenu
+dialog_con +menu +scrollbind +windows
+diff +mksession +signs +writebackup
+digraphs +modify_fname +smartindent -X11
-dnd +mouse -sound -xfontset
-ebcdic -mouseshape +spell -xim
+emacs_tags +mouse_dec +startuptime -xpm
+eval -mouse_gpm +statusline -xsmp
+ex_extra -mouse_jsbterm -sun_workshop -xterm_clipboard
+extra_search +mouse_netterm +syntax -xterm_save
system vimrc file: "$VIM/vimrc"
user vimrc file: "$HOME/.vimrc"
2nd user vimrc file: "~/.vim/vimrc"
user exrc file: "$HOME/.exrc"
defaults file: "$VIMRUNTIME/defaults.vim"
fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DMACOS_X -DMACOS_X_DARWIN -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl@1.1/lib -L/usr/local/opt/readline/lib -L/usr/local/lib -o vim -lm -lncurses -liconv -lintl -framework AppKit -L/usr/local/opt/lua/lib -llua5.4 -mmacosx-version-min=11.2 -fstack-protector-strong -L/usr/local/lib -L/usr/local/Cellar/perl/5.32.1_1/lib/perl5/5.32.1/darwin-thread-multi-2level/CORE -lperl -L/usr/local/opt/python@3.9/Frameworks/Python.framework/Versions/3.9/lib/python3.9/config-3.9-darwin -lpython3.9 -framework CoreFoundation -lruby.3.0 -L/usr/local/Cellar/ruby/3.0.1/lib
And I'm using the latest coc and coc-git versions.
jq .version ~/.config/coc/extensions/node_modules/coc-git/package.json
"2.3.2"
This is my config: https://github.com/luisdavim/dotfiles/blob/master/files/vim/config/07.coc.vim#L24-L29 and that was working before the last update.
My config actually matches the one from https://github.com/neoclide/coc.nvim/blob/release/Readme.md so it should be supported...
If I do the following it works:
- edit a file
- set signcolumn=auto
- CocRestart
- set signcolumn=number
However this doesn't:
- edit a file
- set signcolumn=number
- CocRestart
- set signcolumn=number
So, if when Coc starts signcolumn is set to yes or auto it works but if it's set to number it doesn't.
This seems like a regression since it used to work with signcolumn=number out of the box and doesn't anymore.
BTW, the coc-diagnostics signs show just fine with my setup so it's not a coc issue and it seems specific to this extension.
Tried vim 8.2.2850, can't reproduce, please use minimal vimrc.