neo-project / neo

Describe the bug
After upgrading to neo v3.7.4, the plugins command in neo-cli won't show custom installed plugins.

To Reproduce
Steps to reproduce the behavior:

Open the project, install any custom plugin
Type 'plugins'

Expected behavior
show custom plugin's information

Screenshots

Platform:

Version [e.g. neo-cli 3.7.4]

(Optional) Additional context
This should be related to #3092.

I don't want to hurt someone here. But for NEO's stability, I personally suggest that you should pay more attention to https://github.com/cschuchardt88's PR. IIRC, neo-project/neo-modules#897 also find some bugs introduced by cschuchardt88. He has introduced so many big PRs that changes a lot, especially there are many opening now. Let's move carefully.

That's a good point to bring. In #3092 the already existing code that was updated. Did display other plugins, only the plugins from github. We are going to be reworking this anyways. Because after this release plugins will not be at that URL anymore or that repo.

neo> plugins
[Not Installed]  ApplicationLogs
[Installed]      DBFTPlugin       @3.7.4  Consensus plugin with dBFT algorithm.
[Not Installed]  LevelDBStore
[Not Installed]  MPTTrie
[Not Installed]  OracleService
[Not Installed]  RocksDBStore
[Not Installed]  RpcClient
[Not Installed]  RpcServer
[Not Installed]  SQLiteWallet
[Not Installed]  StatesDumper
[Not Installed]  StateService
[Not Installed]  StorageDumper
[Not Installed]  TokensTracker

it works for me, could you give us more information?

I have an idea, I will fix it

Its for custom plugins, I'm guessing he has his only plugin that he made. Below should be the other way around.

neo/src/Neo.CLI/CLI/MainService.Plugins.cs

Lines 231 to 237 in c8f9338

    
                           var plugins = GetPluginListAsync().GetAwaiter().GetResult(); 
        
                           if (plugins == null) return; 
        
                           plugins 
        
                           .Order() 
        
                           .ForEach(f => 
        
                           { 
        
                               var installedPlugin = Plugin.Plugins.SingleOrDefault(pp => string.Equals(pp.Name, f, StringComparison.CurrentCultureIgnoreCase));

The problem is when the plugin list can't be retrieved, because it's wrong configured or a network error., fixed in #3269

The problem is when the plugin list can't be retrieved, because it's wrong configured or a network error., fixed in #3269

I think that @cschuchardt88 fully understood what problem I faced. I'm not sure if this PR fixed that problem. Apart from official plugins, I have my own plugins.

Anyway, thanks for fixing this. I'll reopen it if the problem still exist in the next version.

I see, @lingyido .

let's re-open in this case.

@cschuchardt88 If you knew and tested that this issue has been fixed, please tell us and close this. I'm not sure that if @shargon get my point.

I will let you reopen.

	var plugins = GetPluginListAsync().GetAwaiter().GetResult();
	if (plugins == null) return;
	plugins
	.Order()
	.ForEach(f =>
	{
	var installedPlugin = Plugin.Plugins.SingleOrDefault(pp => string.Equals(pp.Name, f, StringComparison.CurrentCultureIgnoreCase));

[NEO.CLI] custom plugins won't shown by command `plugins`