Not finding branch name

Question

Not finding branch name

IgorRebeche opened this issue 3 years ago · comments

Hello, today i tried to prune my branches using your approach but when i tried to delete some error occurred as you can see in the screenshot

I think it can be a problem with the deleteBranches implementation in find-stale.js.
It is using single quotes

i would change the line 256

var exec = utils.asyncExec(['git', 'branch', dFlag, "'" + branchName + "'"]);

To

var exec = utils.asyncExec(['git', 'branch', dFlag, branchName ]);

I am using windows, maybe in linux could work with single quote but i didn't test yet

Raz Halaly · Answer 1 · Wed Aug 25 2021 17:27:03 GMT+0800 (China Standard Time)

I'm having the same issue. I want to add extra information:
If I get the error:

ERROR: Unable to remove: Command failed: git branch -D 'feature/add-button'
error: branch ''feature/add-button'' not found.

But if I run the exact same command (with the single quote) in the console manually, it works as expected:

 C:\Code\Project\*****> git branch -D 'feature/add-button'
 Deleted branch feature/add-button (was *****).

I'm running this on Windows

Németh Gábor · Answer 2 · Wed Aug 25 2021 17:58:40 GMT+0800 (China Standard Time)

Hi,

I've made that change because of #6 in #8 . It works on macOS and Linux. I'll try to figure it out what's different on Windows and make a fix for it.

DerZyklop · Answer 3 · Wed Oct 13 2021 17:22:18 GMT+0800 (China Standard Time)

@erkage @nemisj I confirm: It works on macOS. It does not work on Win.

I can run both git branch -d 'foo' and git branch -d foo successfully on my mac.

My Win colleagues can run git branch -d foo successfully, but when they run git branch -d 'foo', they get the Error
branch ''foo'' not found

Maks Nemisj · Answer 4 · Wed Oct 13 2021 17:28:29 GMT+0800 (China Standard Time)

Even on v1.0.4? @DerZyklop

DerZyklop · Answer 5 · Wed Oct 13 2021 21:08:30 GMT+0800 (China Standard Time)

@nemisj yes. We are on 1.0.4 for ~two months now.

DerZyklop · Answer 6 · Wed Oct 13 2021 21:10:56 GMT+0800 (China Standard Time)

@nemisj which makes sense. With 1.0.3 the problematic single quotes came in. The 1.0.4 release only contains text changes in README.md

Maks Nemisj · Answer 7 · Wed Oct 13 2021 21:31:07 GMT+0800 (China Standard Time)

@DerZyklop yes, indeed, sorry.
I will have a look at this one.

Maks Nemisj · Answer 8 · Thu Oct 14 2021 04:00:08 GMT+0800 (China Standard Time)

1.0.5 should fix that @DerZyklop @IgorRebeche, can you please confirm?
@IgorRebeche, sorry for such a long answer, there is some issues with notifications to my email, haven't seen your message.

DerZyklop · Answer 9 · Wed Oct 27 2021 23:35:56 GMT+0800 (China Standard Time)

Tested it with 2.0.1 on Mac and Win.
Confirmed. Bug is fixed.
Thank you 💚

DerZyklop · Answer 10 · Mon Nov 29 2021 21:12:18 GMT+0800 (China Standard Time)

@rhalaly Thanks for reporting, but your issue is not related to this ticket. And it’s also not a bug.

The message says "branch … is not fully merged". This means the branch exists, and the git-removed-branches command could find it, but It contains changes that have not been merged into your main branch yet.

✌

Raz Halaly · Answer 11 · Mon Nov 29 2021 23:37:42 GMT+0800 (China Standard Time)

@DerZyklop it was a false alarm, indeed. Sorry!