Pretty please make default root Margin 0

Question

Pretty please make default root Margin 0

mylescc opened this issue 6 years ago · comments

Myles Cowper-Coles commented 6 years ago

Hi there,

Long term fan here.

Just wondering if you could make the default root margin 0 rather than 200px x 200px. Wouldn't that make more sense?

Yours,

TRIBE

Adam Duncan · Answer 1 · Sat Dec 15 2018 00:27:32 GMT+0800 (China Standard Time)

Also aligns with default options expected from IntersectionObserver.

Big fan. First time caller.

Adam Duncan · Answer 2 · Sat Dec 15 2018 00:31:18 GMT+0800 (China Standard Time)

Sorry, @neefrehman – where is this feature? I've been waiting for ages!

Neef Rehman · Answer 3 · Mon Dec 17 2018 00:29:01 GMT+0800 (China Standard Time)

Hi @mylescc @adamduncan, thanks for reaching out.

I'll be keeping the default root margin value as 200px. This script is for lazy loading images as they approach the viewport, so a non-zero root margin value will give some time for the image to load, which provides a better user experience as there won't be many blank spots on the page (provided a normal scrolling speed and well-optimised images). Obviously to do it in this way It will have to stray from the default option for IntersectionObserver.

Most other lazy-loading scripts have a similar approach (rightly so, I feel).

If you'd prefer to use a value of 0 then you can set that when calling lzy, as I've explained in the readme, or you can also hardcode the default value in the lzy.js file, if you feel you're up to it.

Marking this issue as closed.