Giters

nedbat / dinghy

A GitHub activity digest tool

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

1.3.1 - Since parameter ignored in yaml config

ltvolks opened this issue · comments

commented

It looks like 1.3.1 introduced a bug that ignores the since parameter in yaml config

The dinghy_sample repo reports show that it is defaulting to 1 week regardless of configuration:

created at 2023-09-19 13:06 by dinghy 1.3.1.

dinghy.yaml

 
# This is used to create the sample digest for the readme.

defaults:
  title: Sample Dinghy report
  items:
    - https://github.com/psf/black

digests:
  - digest: 1week.html
    since: 1 week

  - digest: 3day.html
    since: 3 day

  - digest: 1day.html
    since: 1 day

1.3.1 debug

Note: Incorrect param for 3 days and 1 day:

  • 1 week: since: '2023-09-12T14:00:54'
  • 3 days: since: '2023-09-12T14:00:54'
  • 1 day: since: '2023-09-12T14:00:54'
date && dinghy --version && dinghy -v DEBUG dinghy.yaml

Tue Sep 19 14:00:53 CDT 2023
dinghy, version 1.3.1
debug: query getRepoIssues(owner: 'psf', name: 'black', since: '2023-09-12T14:00:54')
debug: query getPullRequests(owner: 'psf', name: 'black')
debug: query getRepoReleases(owner: 'psf', name: 'black', since: '2023-09-12T14:00:54')
debug: query getRepoIssues(owner: 'psf', name: 'black', since: '2023-09-12T14:00:54')
debug: query getPullRequests(owner: 'psf', name: 'black')
debug: query getRepoReleases(owner: 'psf', name: 'black', since: '2023-09-12T14:00:54')
debug: query getRepoIssues(owner: 'psf', name: 'black', since: '2023-09-12T14:00:54')
debug: query getPullRequests(owner: 'psf', name: 'black')
debug: query getRepoReleases(owner: 'psf', name: 'black', since: '2023-09-12T14:00:54')
debug: query getPullRequests(owner: 'psf', name: 'black', after: 'Y3Vyc29yOnYyOpK5MjAyMy0wOS0xM1QwMjo0MDo0NS0wNTowMM5aL_K6')
debug: query getPullRequests(owner: 'psf', name: 'black', after: 'Y3Vyc29yOnYyOpK5MjAyMy0wOS0xM1QwMjo0MDo0NS0wNTowMM5aL_K6')
debug: query getPullRequests(owner: 'psf', name: 'black', after: 'Y3Vyc29yOnYyOpK5MjAyMy0wOS0xM1QwMjo0MDo0NS0wNTowMM5aL_K6')
Wrote digest: 3day.html
Wrote digest: 1day.html
Wrote digest: 1week.html
debug: Remaining graphql rate limit: 3594 of 5000, next reset at 14:38:42

1.3.0 debug

Note: Expected params for

  • 1 week: since: '2023-09-12T14:02:22'
  • 3 days: since: '2023-09-16T14:02:22'
  • 1 day: since: '2023-09-18T14:02:22'
date && dinghy --version && dinghy -v DEBUG dinghy.yaml

Tue Sep 19 14:02:17 CDT 2023
dinghy, version 1.3.0
debug: query getRepoIssues(owner: 'psf', name: 'black', since: '2023-09-12T14:02:22')
debug: query getPullRequests(owner: 'psf', name: 'black')
debug: query getRepoReleases(owner: 'psf', name: 'black', since: '2023-09-12T14:02:22')
debug: query getRepoIssues(owner: 'psf', name: 'black', since: '2023-09-16T14:02:22')
debug: query getPullRequests(owner: 'psf', name: 'black')
debug: query getRepoReleases(owner: 'psf', name: 'black', since: '2023-09-16T14:02:22')
debug: query getRepoIssues(owner: 'psf', name: 'black', since: '2023-09-18T14:02:22')
debug: query getPullRequests(owner: 'psf', name: 'black')
debug: query getRepoReleases(owner: 'psf', name: 'black', since: '2023-09-18T14:02:22')
Wrote digest: 1day.html
Wrote digest: 3day.html
debug: query getPullRequests(owner: 'psf', name: 'black', after: 'Y3Vyc29yOnYyOpK5MjAyMy0wOS0xM1QwMjo0MDo0NS0wNTowMM5aL_K6')
Wrote digest: 1week.html
debug: Remaining graphql rate limit: 3485 of 5000, next reset at 14:38:42
commented

This is now released as part of 1.3.2.