ned14 / status-code

Proposed SG14 status_code for the C++ standard

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"'noreturn' function does return" warning for indirecting_domain::_do_throw_exception

lzhangzz opened this issue · comments

Getting an "'noreturn' function does return" warning for the function

SYSTEM_ERROR2_NORETURN virtual void _do_throw_exception(const status_code<void> &code) const override // NOLINT

Shall we insert an abort() for it?

There is annoying bug in some versions of GCC where virtual functions and the noreturn attribute don't seem to work well together. They fixed it in newer GCCs, and clang and MSVC never had the problem.

Does inserting an abort here fix the warning for you?

Does inserting an abort here fix the warning for you?

Yes

Thanks for the BR!