`packed_backtrace.hpp` missing includes with `QUICKCPPLIB_USE_STD_SPAN`

[Henrik Gaßmann]

quickcpplib/include/quickcpplib/packed_backtrace.hpp

Lines 26 to 35 in a47807c

 #define QUICKCPPLIB_PACKED_BACKTRACE_HPP 
  
 #include "config.hpp" 
 #include "span.hpp" 
  
 #include <cstddef>  // for ptrdiff_t etc 
 #include <cstdint>  // for uint32_t etc 
 #include <cstring>  // for memset 
  
 QUICKCPPLIB_NAMESPACE_BEGIN 

However, the file contains

quickcpplib/include/quickcpplib/packed_backtrace.hpp

Line 317 in a47807c

 abort(); 

and

quickcpplib/include/quickcpplib/packed_backtrace.hpp

Line 405 in a47807c

 throw std::out_of_range("packed_backtrace: out of range"); 

which relies on <cstdlib> and <stdexcept> being included by "span.hpp". This is the case for gsl / span-lite, but both gcc and msvc standard library implementations of span include neither of them. Therefore QUICKCPPLIB_USE_STD_SPAN is currently somewhat broken.

[Niall Douglas]

Many thanks for the bug report!

[Henrik Gaßmann]

@ned14 thanks for fixing this promptly!

Just a heads up: The IntelliSense/EDG version included in the upcoming VS 16.8 release ICEs somewhere in outcome's basic_result.hpp, i.e. IntelliSense will be disabled for everything (transitively) including basic_result.hpp.

[Niall Douglas]

Well that sucks. I'm not onto 16.8, but when it releases I'll go prod Microsoft if it's still there. You may not be aware that Outcome trunk is within VS's test suite, so they tend to notice quickly when Outcome blows their stuff up.