nebulasio / neb.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Neb API arguments check

qywang2012 opened this issue · comments

Nebulas currently have a usable js version to create the wallet address and send the transaction. Neb. js implements all the RPC interfaces of the Nebulas, but none of these interfaces currently add parameter validation.

We should add parameter validation to these interfaces and functions.

RPC interfaces:

Functions

  • Transaction: The parameters of the constructor need to be checked.
    • chainID should be valid(1 Mainnet, 100[1/2/...] Testnet)
    • from must be a valid address with a private key
    • nonce must be a number

Can some guys give help for the parameter check?

Issue status update: Help is still needed from community :)

commented

can we improve this with a typescript definition file?