Highlighting in Command Palate makes menu text difficult to read

[Aidan Beery]

Hi, when using Penumbra Dark, Contrast+, or Contrast++, the highlighted menu text in vscode's command palate becomes very difficult to read. It looks as if it's using the highlight color from Penumbra Light. The grey text and cream highlight does not have enough contrast to read quickly.

Here's an example of similar menu highlighting in One Dark Pro

[Alois Carrera]

@Aidan-B1409 if you want, you can overwrite the color values for list.activeSelectionBackground in your editor global settings, using this:

"workbench.colorCustomizations": {
  "[Penumbra Dark Contrast++]": {
    "list.activeSelectionBackground": "#2c313a"
  }
}

[Neal McKee]

The inversion was somewhat of a deliberate choice based on the template I was working off, I could see how the text has too little contrast though.

One Dark actually makes only a tiny distinction between hovering and selecting whereas I think it’s more useful to have it be much bigger. My suggestion would be to keep the inversion and increase the contrast which would look like this for the regular Dark version:

Other options would be to increase the contrast even further (I don’t think it’s necessary at first glance) or to forego the inversion and rework the highlighting in lists completely.

I’ll wait a bit for opinions before I make this update:
👍 for the proposed change
👎 for no inversion
🚀 for more contrast