ncuillery / rn-diff

Easier React Native upgrades by clearly expose changes from a version to another. :rocket:

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

0.57.0

erickzanardo opened this issue · comments

commented

Hello

0.57.0 was released 5 days ago opening this just for a reminder :)

PRs are welcome \o/

commented

I would love to open a PR, but I guessed by reading this section of the README:

How can I contribute ?
Unfortunately you can't ;). Correct me if I'm wrong but due to the particular structure of the branch tree, it's impossible to collaborate in the classic way (Pull Request on a non-existing branch).

That it was not possible, any way to submit a PR?

I've seen forks that submitted the diff before this repo.

commented

@ryankask thanks for the reply,

I had problems regarding upgrading RN from 0.56.0 to 0.56.1 too (like you said on #33), when I get home from work I will see if I can generate the diffs.

Thanks

trying to see whats wrong with the upgrades

i cant figure it out. i am tempted to create a new RNApp in 0.57.0 and then do a diff, to see.
in fact, ill just do that now.

i created a new diff, 0.55.4 -> 0.57.0, by creating a new project over the old one and getting the actual diff. i could not find a nice quick way to do all the steps. 0.55.4 was the last easy babel 6 version, and 0.57.0 is the first easy babel 7 version.
i hope that is enough for people.
shall i close this or do we need something more?

commented

What fixed the RN 0.56.0 upgrade for me was this

RN 0.56.0 seems to have some issues related to babel and I was not able to use it after the upgrade, only after updating that preset

i saw comments like this, many with different versions of the babel preset, babel-core, @babel/core, metro etc. i thought that the cleanest most correct way is to recreate it. if other things worked, be my guest and upload them or make a pr, but for me the manual 57 is good.

I think we should revert the latest README changes and delete the rn-0.57.0 branch and do 0.56.0 to 0.56.1 and then 0.56.1 to 0.57.0 manually.

It doesn't look like there were any changes which matches my fork's branches.

for the last part, what do you mean?
for the first part, sure it could be done, but I didn't want to spend any more time for upgrading my apps that were 0.55.4, so I made that one. feel free to make the other ones. :)

Please ignore the second part.

It makes sense to do what works for you but I would do it on your fork. It's confusing because this project's README.md isn't consistent because of ee230cd:

2018-09-19 at 15 20

I agree that it's inconsistent. I could add like a '*' so it shows it's different and not a one step up.

0.57.7 is out, I can't help but notice the repo is behind a few versions. Where do I start if I would like to help add the missing versions