ncipollo / release-action

An action which manages a github release

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Is artifactContentType useful to set?

Hipska opened this issue · comments

Does the setting artifactContentType actually has any effect?

When using the most common example of application/zip for a ZIP file, this does not seem to be reflected in the icon on the actual release page:
image

So, is there any benefit of setting this parameter? Why not always use raw?

I verified this is being pass down into the github API, so not sure. The API docs make it sounds like it would be used but Github or octokit might have more logic around this to prevent misclassification of assets (which could be a security concern).

I also tracked it down to the OctoKit. I see no benefit of specifying something else than raw are this point.

There might be some usecases where this is useful which are buried in documentation somewhere. I figure it's probably safer to leave it as an option in case someone has a legit need for it.