Some dates in october can't be selected
andrefpc opened this issue · comments
Hello,
I tryed to use the plugin, but I found a little bug.
When i choose dates between 2017-10-16 and 2017-10-31, the background of date don't change and seems not mached.
I made a test on DEMO aplication, exposed in github, and the problem appears too.
Can you make a live demo?: https://github.com/nazar-pc/PickMeUp#contribution
The problem occurs in your demo!
Try to select "2017-10-24", this date will not be selected.
Here on github and on jsfiddle works perfectly for me
This is strange, because here a make tests in more than one browsers and the problem persists. Only for dates between 2017-10-16 and 2017-10-31!
Are you sure your OS is up to date?
Can't reproduce myself and I know no reason why it might not work properly.
I'm sure.
The error are unexplainable, but occurs in my tests!
I make tests in demo page and the problem persists. Can you resolve that issue?
Tested in SO Linux Mint, Browser Google Chrome 61 and Firefox 55
I can't resolve issue that I can't reproduce, please help me to do this. I can select any date on any month in any mode without issues.
My OS is Ubuntu 17.10 x64 with all updates and browsers are Nightly builds of Firefox and Chromium.
- In which mode (single date, range or multiple) you can't select date?
- Can you record a screencast with this issue?
- What exactly version of Linux Mint are you using (version and flavor, so that I can install exactly the same version in VM)? (and make sure you have all available updates are installed)
- Also which timezone are you using?
RELEASE=18
CODENAME=sarah
EDITION="Xfce 64-bit"
DESCRIPTION="Linux Mint 18 Sarah"
DESKTOP=Xfce
TOOLKIT=GTK
NEW_FEATURES_URL=http://www.linuxmint.com/rel_sarah_xfce_whatsnew.php
RELEASE_NOTES_URL=http://www.linuxmint.com/rel_sarah_xfce.php
USER_GUIDE_URL=help:linuxmint
GRUB_TITLE=Linux Mint 18 Xfce 64-bit
- Time zone: America/Sao_Paulo (BRT, -0300)
I'm having the same issue... I tried to log in line 508 of pickmeup.js and got this:
console.log('111', _AAAAAA, options.date, val, day_element) (_AAAAAA means the 'if condition' down the line 508)
15-10-2017
16-10-2017
17-10-2017
As you can see, when I click in 15-10-2017, options.date and val are equal, but when I click 16-10-2017 and 17-10-2017, they are different... I'm trying to debug more here to get solutions.
I think the problem is with Daylight Time... In Brazil we're going to add one hour, so from UTC-3 we're going to UTC-2... I think this mess with the .valueOf() calculation
I added local_date.setHours(0); to line 477 from pickeup.js and it worked.
With your timezone I was able to reproduce an issue and I've just committed c6c8744 that is intended to fix it.
Test it, please, before I publish new release to NPM.
I've just released new version 3.0.9, it should fix the issue, let me know if you have other issue