naveedgol / music-web-player

Web player for Apple Music

Home Page:https://naveedgol.github.io/music-web-player/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't run it natively (using nativefier)

oquirozm opened this issue · comments

Hi! Awesome app. I tried creating an electron version using nativefier but every time the app tries to make a request it opens the request's url in my browser. Is there anything I can do to prevent that? Is there anything that can be done to prevent it? It makes it unusable as a native electron app.

This is because nativefier will automatically try and open any external-urls outside the electron-app. To force it to consider the url as "internal" this has to be specified on the command line.

example:
nativefier --name "Play Apple Music" --internal-urls ".(itunes.apple.com)."

But this will still fail due to getting a 405 (method not allowed) from the authenticateMusicKitRequest :/

@alx242 I haven't checked the MusicKit documentation so correct me if I'm wrong but isn't the use of external-urls to perform actions inside the app a consequence of using Angular? Would using different tools (e.g. React) help solve the issue?

I tried to run it as an Electron app as well and ran into blank auth popups. This is the same issue described in #17. Given that MusicKit handles all new tab behavior, this is beyond my control.