nature-of-code / noc-book

The Nature of Code book (archived repo, see README for new repo / build system!)

Home Page:http://natureofcode.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Screenshot images should have thin outline

shiffman opened this issue · comments

1st edition:

screen shot 2016-07-11 at 10 43 27 am

2nd edition:

screen shot 2016-07-11 at 10 43 41 am

There also looks like there is some sort of gradient / dropshadow above the image that should probably be removed?

That was a try based on a previous comment on the CSS code:

// Need a magic solution for border side borders to be partial, not extend all the way to top

( 0d8fcab#diff-a134daaa45c2acf81732f755c99288b5L308 )

There was also a note on the pdf file from the dropbox (noc_dw_02.pdf) on those screenshot to make them look with a slight dropping shadow. I've switched back to the previous hard border version ( 7b0ee4b ) as anyway the PDF render wasn't the same as in the browser.

I leave the issue open just in case we want to put there the drop shadows

Ah, now I remember. The drop shadows looked nice in the design, but the actual printer doesn't have the ability to render such fine gray details so they didn't look good in the physical book. Print quality may have improved from 3-4 years ago, but I think let's stick to no drop shadows for now.

ok no problem, we can close this.