nats-io / nack

NATS Controllers for Kubernetes (NACK)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stream Template crd not served

oshkiole opened this issue · comments

Hi,
While working on a project that was supposed to use stream templates for dynamic stream creation we found out that stream templates are declared in crds file, but marked as not served. Are they not served due to some issue directly in NACK or are they missing version v1beta2? Because, as I see, all other resources have versions v1beta1 and v1beta2, but stream templates only have v1beta1.

nack/deploy/crds.yml

Lines 677 to 692 in 552472d

---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
name: streamtemplates.jetstream.nats.io
spec:
group: jetstream.nats.io
scope: Namespaced
names:
kind: StreamTemplate
singular: streamtemplate
plural: streamtemplates
versions:
- name: v1beta1
served: false
storage: true

Hi @oshkiole the streamtemplate feature from JetStream does not work in clustering mode so we decided to remove them from the v1beta2 CRDs.

@wallyqs Thank you for your reply. Do you know is this issue going to be fixed in future? In my project we already moved to a different solution, but this would be good to know.

@oshkiole not sure if they will be fixed for clustering, I think they might get deprecated in their current form and revisited in the future