nats-io / nack

NATS Controllers for Kubernetes (NACK)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stream MaxBytes not set during create

jdolce opened this issue · comments

Looks like during a recent re-factor max bytes is no longer being set on stream creates.

https://github.com/nats-io/nack/blob/main/controllers/jetstream/stream.go#L163

Seems to be a result of this commit 74d1ddc

I took a look at changing this, which is a really simple change. However, I think some better tests are in order which will help catch these sorts of errors in the future. Would be nice to check the stream config after it has been created.

Current status of branch with e2e tests is here: https://github.com/nats-io/nack/commits/minikube

I'm thinking we should separate the two tasks here.

  • The actual issue here could be solved with #60
  • The e2e tests can be tracked at #59