nativescript-vue / nativescript-vue-navigator

A simple router for NativeScript-Vue, built on top of $navigateTo to simplify routing from within components

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implicitly set an id to the `Navigator` frame

rigor789 opened this issue ยท comments

When creating a Navigator frame, we should implicitly set an id and not use the default one.

The issue is when you have multiple frames, you might run into a situation where both the Navigator and your Frame will try to use the same ID.

In NativeScript-Vue 2.5.0 we removed the frame-id collision handling, as it was causing another set of issues (nativescript-vue/nativescript-vue#532), causing the last created Frame instance with a given id to overwrite the previous one in the Frame lookup table causing unexpected navigation behaviour.

The fix is simple, we can add a new id property with a default value of navigatorFrame for instance, and refactor all calls to $navigateTo and $navigateBack to include this id as a navigation option.

๐ŸŽ‰ This issue has been resolved in version 1.0.0 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€