use require.resolve to fetch script file of mocha-phantomjs-core

Question

use require.resolve to fetch script file of mocha-phantomjs-core

kaelzhang opened this issue 9 years ago · comments

The new NPM(version 3.3.3) will install dependencies directly into the node_modules directory as much as possible rather than installing them hierarchically.

So, there might not be a node_modules directory inside node_modules/mocha-phantomjs/, see here

It's better to do the path.resolve thing with require.resolve()

Nathan Black · Answer 1 · Wed Sep 23 2015 13:02:43 GMT+0800 (China Standard Time)

Good catch, thanks.

Nathan Black · Answer 2 · Wed Sep 23 2015 13:09:00 GMT+0800 (China Standard Time)

4.0.1 has your fix. Thanks.

Kael · Answer 3 · Wed Sep 23 2015 14:28:42 GMT+0800 (China Standard Time)

You are so efficient, buddy! 👍

Nathan Black · Answer 4 · Wed Sep 23 2015 14:40:03 GMT+0800 (China Standard Time)

Yeah 10min from open to fix and published is a new record for me :)