Asserting checkbox checked state?

Question

lolmaus opened this issue 5 years ago · comments

Currently doing this:

expect(checkbox.checked).to.be.true;

I believe, it would read much better as:

expect(checkbox).to.be.checked;

Please??

Nathan Black · Answer 1 · Sat Nov 13 2021 02:53:26 GMT+0800 (China Standard Time)

I like it - I'll accept a PR for the feature!

Andrey Mikhaylov (lolmaus) · Answer 2 · Sat Nov 13 2021 07:12:03 GMT+0800 (China Standard Time)

Can you please provide some guidance?

Nathan Black · Answer 3 · Sat Nov 13 2021 08:50:16 GMT+0800 (China Standard Time)

See #53 - prime example of adding a new assertion with documentation and tests.

Andrey Mikhaylov (lolmaus) · Answer 4 · Fri Nov 26 2021 19:15:06 GMT+0800 (China Standard Time)

Done: #56 .

Andrey Mikhaylov (lolmaus) · Answer 5 · Sun Nov 28 2021 23:47:45 GMT+0800 (China Standard Time)

@nathanboktae Thanks! Are you gonna release it?