Add support for reverse proxy

Question

Add support for reverse proxy

doggy8088 opened this issue 6 years ago · comments

It can be useful to provide a proxy feature in the dotnet-serve that can serve some routes into another site to bypass Same-origin policy in the browser.

Nate McMaster · Answer 1 · Fri May 11 2018 08:09:57 GMT+0800 (China Standard Time)

I'm open to taking this as a PR. Feel free to let me know if you want to implement it.

Will 保哥 · Answer 2 · Fri May 11 2018 19:14:54 GMT+0800 (China Standard Time)

@natemcmaster Is it suitable to integrate https://github.com/Azure/reverse-proxy-dotnet into this project?

Nate McMaster · Answer 3 · Fri May 11 2018 22:26:19 GMT+0800 (China Standard Time)

I'm not very familiar with that project. I was hoping to use https://github.com/aspnet/proxy, but I don't know if the latest released version of it works with .NET Core 2.1. It's still an experimental middleware.

Will 保哥 · Answer 4 · Sat May 12 2018 02:00:50 GMT+0800 (China Standard Time)

@natemcmaster In their samples, do you know why they are using app.UseWebSockets() to run the proxy? I don't understand what's the relationship between WebSockets and Proxy?

Nate McMaster · Answer 5 · Sat May 12 2018 02:22:05 GMT+0800 (China Standard Time)

It allows forwarding websockets connections as well as regular HTTP requests

Will 保哥 · Answer 6 · Sat May 12 2018 03:32:23 GMT+0800 (China Standard Time)

@natemcmaster For the command arguments/options, do you have any recommendation?

I prefer setting all the reverse proxy rules in the dotnet-serve.json-like file. e.g.

{
  "/api/{*path}": {
    "target": "http://back.end/api/{path}",
  },
  "/{*path}": {
    "target": "https://back.end/index.html",
  }
}

What do you think?

Nate McMaster · Answer 7 · Sat May 12 2018 08:33:01 GMT+0800 (China Standard Time)

I’m currently thinking of supporting one proxy url to use as a fallback for requests not satisfied by the local filesystem. So `--proxy <url>`. Anything more than that seems like too much complexity. This tool isn’t meant to replace writing your own ASP.NET Core. So I’m not convinced yet that this should support routing and multiple proxies. That’s not a “no”; I’m just not convinced yet there are compelling scenarios for it. If you think this is important, tell me more about what you need it for.

Will 保哥 · Answer 8 · Sun May 13 2018 02:30:02 GMT+0800 (China Standard Time)

Let's keep it simple at first. I'll find some time to implement this feature. :)

stale · Answer 9 · Thu Dec 27 2018 21:01:43 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 7 days.