GetPassword is broken

Question

GetPassword is broken

ZacharyPatten opened this issue 4 years ago · comments

ZacharyPatten commented 4 years ago

`GetPassword` is broken

Writing "\b \b" will not move up lines in the console, so if the input currently spans multiple lines your backspace breaks (will not back space to previous lines in the console).
It doesn't support Delete, Left/Right Arrow, Home, or End. Or the CTRL modifier.
When pressing keys such as those mentioned in 2. and keys like F1 through F12 it is adding '\0' chars to the resulting string.
The display character should be an optional parameter so the user can choose alternatives to the hard coded '*' character.
Why have ConsoleColor parameters or a prompt on the method? Let other code handle that.
The SecureString is obsolete in .NET Core, so you should probably not include that in packages that target frameworks other than .NET Framework.

Example fixes

I have written my own version of this method that fixes topics1.-5. from above:
Source Code
Example Code

Also, I mentioned that topic 5. from above should be handled by other means than optional parameters on every relevant method; here is an example of a better approach in my opinion:
Source Code
There are example usages in the same file as the source code.

Nate McMaster · Answer 1 · Sun Nov 08 2020 05:49:27 GMT+0800 (China Standard Time)

It seems you know what needs to be fixed. Would you mind raising a pull request?

Nate McMaster · Answer 2 · Sun Nov 08 2020 05:52:27 GMT+0800 (China Standard Time)

Re:

The SecureString is obsolete in .NET Core, so you should probably not include that in packages that target frameworks other than .NET Framework.

I'd rather keep the API until .NET actually deprecates. I know there has been discussion about doing so, but as of .NET 5 this API is still not officially marked as [Obsolete].

ZacharyPatten · Answer 3 · Sun Jun 13 2021 00:05:55 GMT+0800 (China Standard Time)

Sorry for the late response, yes I do know the fix (the example I linked fixes it). But it is a different approach and I would recommend someone test both approaches to see if there are any negatives of my approach in comparison. Although my version fixes this issue, I'm not sure if it introduces any other issues.

github-actions · Answer 4 · Mon Jun 13 2022 10:15:59 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 14 days. Thank you for your contributions to this project.

github-actions · Answer 5 · Mon Jun 27 2022 10:16:03 GMT+0800 (China Standard Time)

Closing due to inactivity.
If you are looking at this issue in the future and think it should be reopened, please make a commented here and mention natemcmaster so he sees the notification.

ZacharyPatten · Answer 6 · Tue Jun 28 2022 23:37:09 GMT+0800 (China Standard Time)

I noticed that a bot closed this, but this is still an open/active issue.

I don't use your library so I haven't been motivated to open a pull request, but all the info on how to fix it was provided for someone willing.

Nate McMaster · Answer 7 · Wed Jun 29 2022 09:55:11 GMT+0800 (China Standard Time)

My stance on this is here #485. I can reopen the issue, but the bot will just close again in a year if no one comes forward to implement a fix.

github-actions · Answer 8 · Thu Jun 29 2023 10:06:37 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 14 days. Thank you for your contributions to this project.

github-actions · Answer 9 · Thu Jul 13 2023 10:10:41 GMT+0800 (China Standard Time)

Closing due to inactivity.
If you are looking at this issue in the future and think it should be reopened, please make a commented here and mention natemcmaster so he sees the notification.