nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

diff-hl colors are barely noticeable

valignatev opened this issue · comments

Hi! Thanks for this awesome theme!
Maybe it's just me, but diff-hl colors seem to be barely noticeable with the dark theme:
image
You can only see borders, but not the background. Light theme diff-hl colors are a bit brighter, but I have to really concentrate on them:
image

My question is if this is an intended colors (e.g. not a bug).

Also, I've noticed this PR: #51, which made colors less bright.
I've checked how were they before this change:
image
I agree, this is to much :) But maybe there could be some sane middle ground?
What do you think?

@valignatev Hey, thanks for the kind words 💜 . Yeah I agree, a middle ground solution would be the best thing to go for. There are already brighter variants of the background colors (ending with the -s suffix), so this should be easy. Fixing it now 😄

That should do it 😄

Wow, that was super fast! Looks perfect now, thanks a lot ❤️