Giters

nasa / earthdata-search

Earthdata Search is a web application developed by NASA EOSDIS to enable data discovery, search, comparison, visualization, and access across EOSDIS' Earth Science data holdings.

Home Page:https://search.earthdata.nasa.gov

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

EDSC-2911: Add keyboard shortcut to toggle advanced search modal

mreese84 opened this issue · comments

commented

Description

Add keyboard shortcut to toggle advanced search when on a page that supports search (/search, /search/granules).

The a button should be used for this shortcut.

Acceptance Criteria

  • When on a search supported page (/search, /search/granules), hitting the a button on the keyboard toggles the advanced search modal active/inactive.
  • When not on a search supported page (/search, /search/granules), hitting the a button on the keyboard has no impact on the application.
commented

Hi, I would like to work on this issue, can you assign me it?

commented

The commit for our first keyboard shortcut can be found here (amongst a few other changes 😄 )

commented

Before submitting a PR, please make sure you have a test for the functionality you've added. A unit test was added for our existing keyboard shortcut with this PR. Thank you!

commented

I have started development yesterday. I'll continue with unit tests today.