naman14 / TimberX

Material theme music player that works across all form factors (phones, wear, auto, cast, assistant) and uses latest tools (Kotlin, Architecture components, Room, Databinding)

Home Page:https://namand.in

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dark/amoled themes

KeziahMoselle opened this issue · comments

I would like to see a dark mode (dark grey / OLED theme) on this app.
It would make this application perfect !

@afollestad
In Timber I used app-theme-engine but that still resulted in too much theming specific code but this project doesn't have that many UI elements.
I think we can use https://github.com/afollestad/aesthetic for adding theming support?

@naman14 we definitely can - although it wouldn't be too difficult to provide a light/dark/amoled theme just with styles.xml (if we leave out color customization for now)

Yeah, Wouldn't be providing color customisation for now, will go ahead with styles for now

Sweet - you can just use custom attributes to switch out colors and such everywhere - and you can use those attributes right in your drawables so there's no need to have multiple icon files defined for different themes @naman14

(similar to Nock Nock)

That was fast ! Thank's 😄