naman14 / TimberX

Material theme music player that works across all form factors (phones, wear, auto, cast, assistant) and uses latest tools (Kotlin, Architecture components, Room, Databinding)

https://namand.in

Some cursors are not closed

costular opened this issue 5 years ago · comments

Diego Francisco Concepción commented 5 years ago

I saw some methods where you aren't closing cursors which is very important for memory handling.

TimberX/app/src/main/java/com/naman14/timberx/util/MusicUtils.kt

Line 174 in df1a7cf

return cursor.getString(column_index)

Aidan Follestad commented 5 years ago

#3 will help

Naman Dwivedi commented 5 years ago

Yeah, should be fixed with #3. Please reopen if there any other places where cursor is not closed