naitoh / rbpdf

Ruby on Rails TCPDF plugin

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Various warnings about operators

jhansen2015 opened this issue · comments

Problem Description:

C:\Users\Josh\Downloads\redmine\redmine-3.3.2>bundle exec rails server webrick -
e production
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:5020: warning: `-' after local variable or literal is interpreted as bin
ary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:5020: warning: even though it seems like unary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:5834: warning: `+' after local variable or literal is interpreted as bin
ary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:5834: warning: even though it seems like unary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:6822: warning: `**' after local variable or literal is interpreted as bi
nary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:6822: warning: even though it seems like argument prefix
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:9283: warning: `-' after local variable or literal is interpreted as bin
ary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:9283: warning: even though it seems like unary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:9331: warning: `-' after local variable or literal is interpreted as bin
ary operator
C:/Applications-64bit/jruby-9.1.8.0/lib/ruby/gems/shared/gems/rbpdf-1.19.0/lib/r
bpdf.rb:9331: warning: even though it seems like unary operator
C:\Users\Josh\Downloads\redmine\redmine-3.3.2>jruby -v
jruby 9.1.8.0 (2.3.1) 2017-03-06 90fc7ab Java HotSpot(TM) 64-Bit Server VM 25.12
1-b13 on 1.8.0_121-b13 +jit [mswin32-x86_64]

This is probably an issue Ruby's parsing and warning system itself, but I resolved it in the module adding a space after each operator, e.g.

Original:

out(sprintf('q %.2f 0 0 %.2f %.2f %.2f cm /I%d Do Q', w * @k, h * @k, xkimg, (@h -(y + h)) * @k, info['i']))

New (change "@h -(y+h)" to "@h - (y+h))"):

out(sprintf('q %.2f 0 0 %.2f %.2f %.2f cm /I%d Do Q', w * @k, h * @k, xkimg, (@h - (y + h)) * @k, info['i']))

Thank you for pointing out.

fixed f345d19