_is_xfce() crashes with Python 3
akdor1154 opened this issue · comments
Jarrad Whitaker commented
on line 138 of HighlightLib/desktop/init.py,
return _readfrom(_get_x11_vars() + "xprop -root _DT_SAVE_MODE", shell=1).strip().endswith(' = "xfce4"')
should perhaps be
return _readfrom(_get_x11_vars() + "xprop -root _DT_SAVE_MODE", shell=1).decode(errors="ignore").strip().endswith(' = "xfce4"')
:)
Nicolas Perriault commented
If that patch works for you, would you mind creating a PR?
Justin Kromlinger commented
PR #61 fixes this for me and is a cleaner solution in my eyes.
Nicolas Perriault commented
Fixed by #61.