TypeError: Cannot read property 'nodeName' of null

Question

TypeError: Cannot read property 'nodeName' of null

mparpaillon opened this issue 7 years ago · comments

Hi,
Thanks for this. It looks cool.

I get this TypeError: Cannot read property 'nodeName' of null error though. I haven't looked at all the code yet but it looks like you're recursively checking the vdom and at some point you try to check the nodeName of null

I think we should add a test on vdom being null here: https://github.com/mzgoddard/preact-render-spy/blob/master/src/preact-render-spy.js#L10

It seems to work when I add this at the beginning of spyWalk:

if (vdom === null) {
  return '';
}

Does it make sense ?

Michel Parpaillon · Answer 1 · Wed Jun 21 2017 00:31:59 GMT+0800 (China Standard Time)

Same problem here: https://github.com/mzgoddard/preact-render-spy/blob/master/src/preact-render-spy.js#L112

Am I using this wrong ?

Mx Corey Frang · Answer 2 · Wed Jun 21 2017 02:09:25 GMT+0800 (China Standard Time)

No, I just don't think we had a test case for <div>{[ null, <div /> ]}</div> type scenario yet.

I'll add a test case real quick

Mx Corey Frang · Answer 3 · Wed Jun 21 2017 02:19:14 GMT+0800 (China Standard Time)

#11 should fix the problem, just waiting for the travis to pass!

Mx Corey Frang · Answer 4 · Wed Jun 21 2017 02:21:17 GMT+0800 (China Standard Time)

Thanks for catching this one!

Let us know if there are other test cases that fail (feel free to write a failing test case for us! 😄 )

Michel Parpaillon · Answer 5 · Wed Jun 21 2017 15:21:32 GMT+0800 (China Standard Time)

Have you npm publish the package ? Or should I install from the github url ?

Mx Corey Frang · Answer 6 · Wed Jun 21 2017 22:51:01 GMT+0800 (China Standard Time)

Sorry I didn't publish it. Maybe Z will today

…

On Jun 21, 2017 00:21, "Michel Parpaillon" ***@***.***> wrote: Have you npm publish the package ? Or should I install from the github url ? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhh6_LvHiSXZuzqmufajqij9qWK1UACks5sGMR8gaJpZM4N_1zl> .

Michel Parpaillon · Answer 7 · Wed Jun 21 2017 22:56:37 GMT+0800 (China Standard Time)

It's OK, I've installed it from github. Works fine :)

Z Goddard · Answer 8 · Wed Jun 21 2017 23:32:05 GMT+0800 (China Standard Time)

@mparpaillon I published the fix in v0.0.2

Mx Corey Frang · Answer 9 · Sat Jul 01 2017 02:52:30 GMT+0800 (China Standard Time)

Heads up @mparpaillon - we are getting pretty close to what we would feel comfortable calling a 1.0.0 -- Do you have any more feedback for us / can you take a look at the README on master / the open PR's and help us sanity check for your use cases?