Doesn't build on Rust 1.18 and 1.19
hcpl opened this issue · comments
Currently synstructure
uses break
with value (a 1.19 feature) in
Lines 2102 to 2111 in dad0b18
Option::get_or_insert
(a 1.20 feature) in Lines 282 to 286 in dad0b18
I see that 1.15 was failing in Travis so it was disabled and some non-1.15 features slipped into the library. But that was months ago, should it be re-enabled again or Rust version has to be bumped?
There is a case about Option::get_or_insert_with
which has a workaround:
Lines 1508 to 1517 in dad0b18
I'd love a PR which re-enables the 1.15 tests, because I'd like to have the same minimum version as syn. It was disabled originally because I didn't have enough time to figure out what was wrong.
Alright, I've changed those parts a bit and now it passes on 1.15 locally. I'll set up a PR a bit later.
You kindly fixed this for me in #15 🎉