myoung34 / docker-github-actions-runner

This will run the new self-hosted github actions runners with docker-in-docker

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pushes do not use latest base image

LordChunk opened this issue · comments

commented

Builds from the deploy.yml don't workflow don't use the latest base image when you push a new commit. This is because the build steps in deploy.yml don't wait for base.yml to finish before starting.

This issue doesn't occur on scheduled builds since there is a significant time between the start of the base image build and the main image build.

That's only true if the pull request modifies the base docker file. For any build it will use whatever the most recent push of base is, which thanks to nightly builds is no more than 24h old. Because thats just not often enough that; I've not considered a solution

If you've got any ideas for a pull request I'm happy to review