myoung34 / docker-github-actions-runner

This will run the new self-hosted github actions runners with docker-in-docker

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Browsers in Runner Image

nikeee opened this issue · comments

I'm currently in a situation where I need a locally installed Chromium and/or Firefox for E2E testing.

As installing one or multiple browsers would add siginificant size to the base image: Is this in the scope of this repository?
Would it be feasable to add another runner image (which is based on the base image) that also contains the latest browsers?

If it's not listed here then it's out of scope

They list these browsers:

Browsers and Drivers

Google Chrome 104.0.5112.101
ChromeDriver 104.0.5112.79
Chromium 104.0.5112.0
Microsoft Edge 104.0.1293.70 (apt source repository: https://packages.microsoft.com/repos/edge)
Microsoft Edge WebDriver 104.0.1293.70
Selenium server 4.4.0

So no Firefox, but Chrome, Chromium and Edge. This would cover my use case for now.

The previous image also had Firefox. Don't know why it was dropped.

I'd prefer the base image remain (relatively) small. I think if we want to make an image on top of a more full-featured base, we might want to look at https://github.com/nektos/act#runners. I'd be happy with providing both a small image and a larger, more complete base for users who need more.

I'd also be onboard for a -full image add that adds more stuff like browsers and not pure languages to the image itself.

There should be some patterns in place if you check the .github/workflow dir for building off the base and using that to build a -full image that adds the supported browsers

Could we just use the current Dockerfile and use some act Runner as a base, as @nmalaguti suggested? This would also reduce some maintaining work on the image.

Its possible, but if someone adds osx or windows or non-ubuntu later we'd be back at square one

I think its worth a PR to see what it would be up against but what I dont want to do is create drift: ie latest being different from latest-full since they would be wildly different

Honestly I'd like to see how to automate mine using the actual runners base and not ubuntu core but its not something ive had time for

Hey @nikeee , I would love to contribute to this issue under Hacktoberfest. How can I get started?

Closing for more info/context in #259