myoung34 / docker-github-actions-runner

This will run the new self-hosted github actions runners with docker-in-docker

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change UID/GUID in the runner image

Otterian opened this issue · comments

Hi,

Thank you for your time and continuing commitment to this project.

Ideally the user in the image should run as UID 1001 and GID 121, as it does in the official runners from GitHub. This in order to be as identical as possible to the official runners, and prevent possible issues with Actions that may be depending on these variables.

We've done this in our downstream derivative of the Ubuntu image: https://github.com/evryfs/github-actions-runner/blob/test-NewImage/Dockerfile#L23-L24 - and it'd be great if it is done here as well. In addition to the mentioned reasons for doing this - dropping root in images is good security practice in general - even if downstream images drop root.

I'd be happy to create a PR for this if you want this implemented. 👍

Please let me know if anything is unclear, or if you have other thoughts about this 😄

If you can scaffold something I can see the value in adding it for sure

For example, when compiling OpenWRT, using root will be warned

resolved by #223

See the usage docs here