myoung34 / docker-github-actions-runner

This will run the new self-hosted github actions runners with docker-in-docker

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Docker not found in armv7 images

pabloromeo opened this issue · comments

Up until recently I was able to run docker stack deploy commands without problems (mounting /var/run/docker.sock on the runner).
However, after updating to the latest ubuntu-bionic image, docker no longer appears to be installed and builds fail due to:

docker: command not found

I've ssh'ed into the runner container and indeed it appears that docker is not installed or not in the path.
image

Has the setup changed recently in regards to calling docker commands on the host?

FYI: I just reverted back to 2.286.1-ubuntu-bionic and it's working again, so there's something different in ubuntu-bionic it seems.

Ill take a look. I did some refactoring and something might have slipped through

@pabloromeo I dont have an arm v7 handy

Can you see if git and docker are working for me in:

  • latest (ubuntu eoan docker pull myoung34/github-runner:latest)
  • ubuntu bionic (myoung34/github-runner:ubuntu-bionic
  • debian sid (myoung34/github-runner:debian-sid)
  • debian bullseye (myoung34/github-runner:debian-bullseye)

by running git --version and which -a docker

I just ran some tests

  • amd64 seems fine, all 4 have docker 20.10.12 and git 2.34.1
  • arm64 seems to also be missing docker and git for ubuntu bionic and debian bullseye. the other 2 show docker 20.10.12 and git 2.34.1
  • armv7 is probably in the same boat as arm64 if you can confirm that would help tremendously

This might be resolved with 8810c62
if you can retest

I confirmed that git and docker are fixed in arm64

Hi!
Yeah, I was about to test the tags you mentioned above. Sure, I'll give it a shot right now.

Stuff seems to be working now with the latest pushed versions:
I've tried both latest and ubuntu-bionic and both now have git version 2.33.1 and docker 20.10.12.
So that last PR seems to have fixed it :)

Awesome thanks for verifying

Sure thing, glad to help!

This seems to be happenning again :( were there new changes that might have broken the install of docker? I'm getting command not found again.

I dont see any errors in the latest builds, Ill dig in and see if i can confirm

ubuntu-bionic is the tag I'm running

I just tested this on arm64:

root@2edcc95635ea:/actions-runner# git --version
git version 2.35.0
root@2edcc95635ea:/actions-runner# docker --version
Docker version 20.10.12, build e91ed57
root@2edcc95635ea:/actions-runner#``` I dont see any errors in the build log, but I dont have an armv7 to test with. ubuntu-bionic seems fine for allt he other architectures i can test (amd64)

One way i've tried exploring the contents of the image is using dive against the armv7 digest for ubuntu-bionic:

dive myoung34/github-runner@sha256:276dd93eb6cf27cc2cba8fcf3058a3d9c9a2c520ded0450719978b580adc52e8

I'm not seeing /usr/bin/docker in there:
image

However, I do see it if I view the layers for other architectures of that same tag (amd64):
image

I got my hands on a raspberry pi 2 with armv7 so ill be looking into this soon

Awesome! Let me know if there's anything I can test from here. I run it on rpi 4.

@pabloromeo how are you running armv7 on a raspberry pi 4?
Feel free to chat me on keybase if its easier than here 🤔

Ah I'm not running the 64bit version of the OS, I've had this cluster running for ages and I've been too lazy to rebuild it.