Cached binaries should be invalidated on Go version changes

Question

Cached binaries should be invalidated on Go version changes

stk0vrfl0w opened this issue 5 years ago · comments

The gobin cache for a given binary isn't invalidated when the version of Go has changed. In practice, this leads to issues when the compilation behavior differs.

As a concrete example, module builds of swagger-go @ 0.20.1 with go 1.12 results in a perfectly fine working binary whereas go 1.13 creates a binary that throws stack traces when trying to generate models. Due to gobin's current caching behavior, one may be lead to falsely believe that the go 1.13 toolchain works fine for building the 0.20.1 version of swagger-go.

Paul Jolly · Answer 1 · Mon Oct 28 2019 19:29:43 GMT+0800 (China Standard Time)

Please can you confirm the version of gobin you are using?

Anthony Cruz · Answer 2 · Tue Oct 29 2019 00:37:13 GMT+0800 (China Standard Time)

I'm installing via "go get", which should be the latest commit: f2461c8

Paul Jolly · Answer 3 · Tue Oct 29 2019 18:52:08 GMT+0800 (China Standard Time)

I'm minded to agree with your suggestion here. Indeed I'm somewhat surprised we didn't do this to start with.

gobin needs a bit of a rewrite and so I'll bundle this up that work.

Ramesh (VK) · Answer 4 · Sun Jun 28 2020 12:40:19 GMT+0800 (China Standard Time)

I just ran into this issue as well. I suspect a simple fix here is to just change the gobinCache location to include runtime.Version() in its path (or alternatively use the version reported by go version). If that is an acceptable fix, I can probably send a PR..