mvasin / react-div-100vh

A workaround for the '100vh' issue in mobile browsers

Home Page:https://react-div-100vh.vercel.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

React version compatibility

bignimbus opened this issue · comments

First, thanks for creating this!

createRef is only supported as of React 16.3, but the peerDependencies show:

"react": ">15",

It probably makes sense to use the legacy ref callback implementation for the time being. I can probably get a patch together reasonably quickly if you'd like.

Hi! I’m glad you find it useful.

A PR is absolutely welcome. Could you write it in a TDD style? First write a failing test for the current code that highlights the problem and then fix the code to make the test pass.

Resolved by #4